Merged
Conversation
Contributor
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
| import sys | ||
| import typing | ||
| import typing as _typing | ||
| if sys.version_info >= (3, 10): |
Member
There was a problem hiding this comment.
since all versions are 3.10+, can we remove this check? this is generated code so not that it matters but weird this is still here
Member
Author
There was a problem hiding this comment.
that's generated, can ignore
| import sys | ||
| import typing | ||
| import typing as _typing | ||
| if sys.version_info >= (3, 10): |
| import builtins as _builtins | ||
| import sys | ||
| import typing as _typing | ||
| if sys.version_info >= (3, 10): |
allisonschiang
approved these changes
Mar 17, 2026
Member
allisonschiang
left a comment
allisonschiang
left a comment
There was a problem hiding this comment.
didn't check generated code too closely beyond my one comment (same thing in three places) but the non generated code looks like it gets the version checking right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make python 3.10 the minimum supported version.
Tested by:
To Review